5.0: Update django.db.models.functions.datetime#2167
Merged
sobolevn merged 1 commit intotypeddjango:masterfrom May 19, 2024
Merged
5.0: Update django.db.models.functions.datetime#2167sobolevn merged 1 commit intotypeddjango:masterfrom
django.db.models.functions.datetime#2167sobolevn merged 1 commit intotypeddjango:masterfrom
Conversation
| class Trunc(TruncBase): | ||
| def __init__( | ||
| self, | ||
| expression: Expression, |
Contributor
There was a problem hiding this comment.
the types on expression do not match django.db.expressions.Func which currently has this typed as Any -- notably these expressions go through parsing and (at the very least) accept str as well
asottile
added a commit
to asottile/django-stubs
that referenced
this pull request
May 29, 2024
fixes regression in typeddjango#2167
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made things!
Update stubs for
django.db.models.functions.datetimefor Django 5.0.django.db.models.functions.datetimedjango.db.models.functions.datetime.TruncBase.__init__'sis_dstargument was removeddjango.db.models.functions.datetime.TruncBase.is_dstwas removeddjango.db.models.functions.datetime.Trunc.__init__'sis_dstargument was removedI have added the necessary
__init__andas_sqlmethods to accommodate the updates in Django 5.0.Related issues
Refs
Upstream PR